16 901 4,709 8 months ago
Comments
Avatar

Would love to have this mod work with everything else in VR as well, Like the Hotline Combo and Lego Studs. Any Chance can get a VR fix for this if you decide to come back too it? Here's my latest crash.txt

Application has crashed: C++ exception
mods/DMC Combo Counter/lua/PlayerManager.lua:3: attempt to call method 'DMCCC_OnKillshot' (a nil value)

SCRIPT STACK

on_killshot() @mods/base/req/core/Hooks.lua:272
chk_killshot() lib/units/enemies/cop/copdamage.lua:3752
original() lib/units/enemies/cop/copdamage.lua:833
damage_bullet() @mods/base/req/core/Hooks.lua:264
give_impact_damage() lib/units/weapons/raycastweaponbase.lua:2953
on_collision() lib/units/weapons/raycastweaponbase.lua:2830
_fire_raycast() lib/units/weapons/raycastweaponbase.lua:958
original() lib/units/weapons/raycastweaponbase.lua:574
fire() @mods/base/req/core/Hooks.lua:264
original() lib/units/weapons/newraycastweaponbase.lua:2079
fire() @mods/base/req/core/Hooks.lua:264
trigger_pressed() lib/units/weapons/raycastweaponbase.lua:467
_check_fire_per_weapon() lib/units/beings/player/states/vr/playerstandardvr.lua:1487
_check_action_primary_attack() lib/units/beings/player/states/vr/playerstandardvr.lua:1318
_update_check_actions() lib/units/beings/player/states/playerstandard.lua:1017
original() lib/units/beings/player/states/playerstandard.lua:446
__update_standard() @mods/base/req/core/Hooks.lua:264
update() lib/units/beings/player/states/vr/playerstandardvr.lua:710
@mods/BeardLib/Hooks/Fixes.lua:431


Callstack:

  payday2_win32_release_vr  (???)     ???                                                 
  payday2_win32_release_vr  (???)     ???                                                 
  payday2_win32_release_vr  (???)     ???                                                 
  payday2_win32_release_vr  (???)     ???                                                 
  payday2_win32_release_vr  (???)     ???                                                 
                  KERNEL32  (???)     BaseThreadInitThunk                                 
                     ntdll  (???)     RtlInitializeExceptionChain                         
                     ntdll  (???)     RtlClearBits
Avatar

Hi Neilular !
Dully noted, tho i don't have any VR equipment so i don't know how I'll eventually test for a fix... We'll figure this out when I can work on a fix.
Just for information to help pinpoint the problem : you say "Hotline Miami" and "Lego studs" doesn't have this problem right ? Can you link me the version you're using ? 'Cause some of my code is loosely based on the Hotline Miami Combo Counter, but now there's also an improved version etc...

Thanks again for the report.

Avatar

@tfkmaster Sure thing! My files for the Lego Studs and Hotline Combo are both currently the active versions being hosted on the website. Here are the links!

Hotline Combo: https://modworkshop.net/mod/30999
Lego Studs: https://modworkshop.net/mod/39721

And Yes, both of these mods installed seamlessly into VR without issue. ^^ They required a little personal tweaking in the setting for HUD positioning so if in a future build having control of where it is placed on the HUD would be an exciting addition! Also I'd be happy to help test out any VR edits if needed.

Avatar

I'm having trouble getting this mod to work, did u237 break this? I have the latest SuperBLT and BeardLib installed as of writing this.

Avatar
(Owner)2 months ago(Edited)

Hi noikun, I didn't play PD2 for some times now and didn't test on U237. I'll try the update and see if this work properly or not, and try to see what i can do if it isn't.
I'll catch you up on this as soon as i can

EDIT : So, I tested with the latest update, both offline and online (and jeebus rice, online is so hard to join rn), and both with minimal setup (SuperBLT + BeardLib) and my usual modded setup, and it worked everytime without any issues. Do you have any logs regarding any mod related issue or something that could somehow conflict with the mod ?
Maybe you can also try and delete the savefile related to the mod config in "Mods/save/DMCCC.txt" to see if it work ""from scratch""

Avatar

@tfkmaster Hey, sorry for letting you experience online u237 lol. I've narrowed down the mods that conflict with this one, it's Better Assault Indicator and Borderless Windowed Updated. If I put either of those mods in, DMCCC doesn't work. Let me know if you need anything like logs and such, and if you do, how/ where to get them.

Thanks for replying.

edit: fresh DMCCC install and playing on u238 with latest BeardLib

Avatar
(Owner)2 months ago(Edited)

@noikun Hi, thanks for narrowing down the conflicts !

Unfortunatly, i don't have much free time to spend on investigating those at the moment, so I can't say honestly when i would work on it :(

You can maybe try to ask Dom for the BAI mod if he's still active on those. Maybe there is some compatibilities patch shenanigans he can do like he did on other HUD mods.
For the windowed borderless one, I don't really know where to start, but it could come from the viewport i'm using to render the little HUD for the ranks being not very good for windowed use or something.

In any case, i can't promise anything for the future but i'll keep that in mind as a priority for when i'll get back into it.

Thanks again and sorry for the inconveniance

P.S : IF someone have a fix or anything to contribute to the mod, you can send me the stuff, make a submod or anything. Don't hesitate to contact me so I can either integrate the stuff directly or link to your stuff in the description (and get you credited in any case of course)

Read All Replies (4 replies)
Avatar

DUDE I LOVE YOU FOR THIS

Avatar

I AM THE STORM THAT IS APPROOOAAACHINGG

Avatar

I cann't possibly think of a better picture for this mod page.

Avatar

This is such an amazing mod but would a volume slider be possible? I can barely hear the announcer in game

Avatar
(Owner)7 months ago(Edited)

Hey Ham, thanks for the feedback !

EDIT : Forget about all this technical stuff

Spoiler!

The current audio is managed using BLT XAudio feature and the sounds are tied to the "sound effect" volume gauge in the game settings.
There is a volume setting in the documentation but it can only attenuate the volume after the game volume is applied (multiplied by a value from 0 to 1)
Somehow in the code of BLT it doesn't seem to force the clamp on this gain setting (maybe the dll does it ?) so i can try to apply this for higher volume.
If it doesn't work, touching BLT don't seem like a good idea so i would probably not touch it unless someone have a very good idea how to do it. (if you do, plz poke :3)

Other things i could try otherwise i making an option to tie the volume to the music setting rather than the sound effect one if you think that can help.

Last resort in any case, you can alter the .OGG to apply gain directly to the audio file, that can maybe help a bit.

I'll try those things when i got time to work on it, in any case i hope you can still enjoy the mod :)

I added the option into the mod ! Gain over 1 is not "officially supported" by SuperBLT sooooo... i don't know if it could bug or something. Butt, it worked for me even with big values so i'll call that a win. Hope it works for you and have a blast ♥

Avatar

@tfkmaster just tested it out with some custom sounds and it works perfectly! Thank you for the addition and keep up the hard work

Avatar

where's my SSSMOKIN SEXY STYLE!?

Avatar

its over

68 1255